Normally do not change a test. but this test fails because it is modified.
Also COINBASE_MATURITY_2 - COINBASE_MATURITY + 1 are not in dgb 7.17.3 ( wallet_tests.cpp ) and not in the original wallet_tests.cpp btc 22 file.

https://github.com/DigiByte-Core/digibyte/pull/31/files
https://github.com/DigiByte-Core/digibyte/pull/32/files
( Cannot find all file that change wallet_tests.cpp )

BTC 22

https://bitcoincore.org/bin/bitcoin-core-22.0/

@Jongjan88 , thank you for the additional context. I do see that the test was changed in PR #62 . However, @SmartArray had made this change in PR #62, which was merged quite a while ago.

@JaredTate or @SmartArray can you provide some feedback on this PR and what changed in the protocol that causes the changes introduced by #62 to fail now?

I am not opposed to approving this if it resolves the test failure but I am first trying to understand the reason @SmartArray had made this change, why that allowed the test to pass for RC1, and why the test is now failing.

@gto90 TY I could not find it. in which file it was modified. And of course I didn't adjust it to Digibyte Core. But change it to the original values.

@gto90 TY I could not find it. in which file it was modified. And of course I didn't adjust it to Digibyte Core. But change it to the original values.

I totally understand @Jongjan88 , I am just hoping to get some feedback from @SmartArray and/or @JaredTate to make sure we don't have an issue in the protocol as I am quite sure @SmartArray had a very valid reason for making that change.

@Jongjan88 , thank you for the additional context. I do see that the test was changed in PR #62 . However, @SmartArray had made this change in PR #62, which was merged quite a while ago.

@JaredTate or @SmartArray can you provide some feedback on this PR and what changed in the protocol that causes the changes introduced by #62 to fail now?

I am not opposed to approving this if it resolves the test failure but I am first trying to understand the reason @SmartArray had made this change, why that allowed the test to pass for RC1, and why the test is now failing.

gto90: "why that allowed the test to pass for RC1, and why the test is now failing."

All the 70/80 python test that don't work with rc3 pass for rc2. @ycagel @gto90 @JaredTate i hope we can review this PR so i can delete the branch. For more info look at pr #62. Where this test is changed to work with rc1.

So it compiles and runs... but Make Check fails long before it ever gets to this file for me. So I am not exactly sure how you are running it and testing it?

So it compiles and runs... but Make Check fails long before it ever gets to this file for me. So I am not exactly sure how you are running it and testing it?

  ./autogen.sh
  ./configure
  make -j 8
  make check

cd src/test
./test_digibyte --run_test=wallet_tests --log_level=message

./test_digibyte --run_test=wallet_tests --log_level=message

Perfect, that makes sense. I fixed the main folder unit tests, so now make check fails on this one for me. So testing this now.

That idiot is posting phishing links. Guess they can spam github with crap now too.